jimlee/dashboard-icons
1
0
Fork 0
mirror of https://github.com/walkxcode/dashboard-icons.git synced 2025-10-26 21:19:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor: simplify header submit button implementation

Browse Source 
- Remove IconSubmissionForm component usage
- Replace with direct Link navigation to /submit
- Simplify mobile and desktop submit button logic
- Remove unused import and improve code clarity
This commit is contained in:
Thomas Camlong
2025-10-02 10:51:17 +02:00
parent 22ac70dc9f
commit 310190f6c1
1 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
web/src/components/header.tsx
View File

@@ -3,7 +3,6 @@
import { Github, LayoutDashboard, LogOut, PlusCircle, Search, Star } from "lucide-react" import { Github, LayoutDashboard, LogOut, PlusCircle, Search, Star } from "lucide-react"
import Link from "next/link" import Link from "next/link"
import { useEffect, useState } from "react" import { useEffect, useState } from "react"
import { IconSubmissionForm } from "@/components/icon-submission-form"
import { LoginModal } from "@/components/login-modal" import { LoginModal } from "@/components/login-modal"
import { ThemeSwitcher } from "@/components/theme-switcher" import { ThemeSwitcher } from "@/components/theme-switcher"
import { REPO_NAME, REPO_PATH } from "@/constants" import { REPO_NAME, REPO_PATH } from "@/constants"
@@ -149,14 +148,12 @@ export function Header() {
{/* Mobile Submit Button */} {/* Mobile Submit Button */}
<div className="md:hidden"> <div className="md:hidden">
{isLoggedIn ? ( {isLoggedIn ? (
<IconSubmissionForm <Button variant="ghost" size="icon" className="rounded-lg cursor-pointer transition-all duration-300 hover:ring-2" asChild>
trigger={ <Link href="/submit">
<Button variant="ghost" size="icon" className="rounded-lg cursor-pointer transition-all duration-300 hover:ring-2"> <PlusCircle className="h-5 w-5 transition-all duration-300" />
<PlusCircle className="h-5 w-5 transition-all duration-300" /> <span className="sr-only">Submit icon(s)</span>
<span className="sr-only">Submit icon(s)</span> </Link>
</Button> </Button>
}
/>
) : ( ) : (
<Button <Button
variant="ghost" variant="ghost"
@@ -171,13 +168,15 @@ export function Header() {
</div> </div>
<div className="hidden md:flex items-center gap-2 md:gap-4"> <div className="hidden md:flex items-center gap-2 md:gap-4">
{/* Desktop Submit Button */}
{isLoggedIn ? ( {isLoggedIn ? (
<IconSubmissionForm /> <Button variant="outline" className="hidden md:inline-flex cursor-pointer transition-all duration-300 items-center gap-2" asChild>
<Link href="/submit">
<PlusCircle className="h-4 w-4 transition-all duration-300" /> Submit icon(s)
</Link>
</Button>
) : ( ) : (
<Button onClick={handleSubmitClick}> <Button variant="outline" className="hidden md:inline-flex cursor-pointer transition-all duration-300 items-center gap-2" onClick={handleSubmitClick}>
<PlusCircle className="h-4 w-4 mr-2" /> <PlusCircle className="h-4 w-4 transition-all duration-300" /> Submit icon(s)
Submit icon
</Button> </Button>
)} )}
<TooltipProvider> <TooltipProvider>